magic-modules Fix universe_domain for ADC and access token auth cases

https://github.com/GoogleCloudPlatform/magic-modules/pull/9799 was too heavy handed and completely broke ADC and auth token access when universe_domain was configured in Terraform.

We can only compare configured universe_domain to the credentialed universe_domain when config.Credentials is set. All other cases should default to the configured value.

Release Note Template for Downstream PRs (will be copied)

provider: fixed application default credential and access token authorization when `universe_domain` is set

Apr 24 '24 11:04 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 13 insertions(+), 10 deletions(-)) google-beta provider: Diff ( 1 file changed, 13 insertions(+), 10 deletions(-))

Apr 24 '24 11:04 modular-magician

/gbcrun

Apr 24 '24 11:04 c2thorn

Tests analytics

Total tests: 3631 Passed tests: 3265 Skipped tests: 365 Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

Apr 24 '24 12:04 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccPrivilegedAccessManagerEntitlement_privilegedAccessManagerEntitlementProjectExample_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

Apr 24 '24 12:04 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 27 deletions(-)) google-beta provider: Diff ( 2 files changed, 20 insertions(+), 27 deletions(-))

Errors

google provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

The diff processor failed to build. This is usually due to the downstream provider failing to compile.

May 13 '24 11:05 modular-magician

Tests analytics

Total tests: 0 Passed tests: 0 Skipped tests: 0 Affected tests: 0

Click here to see the affected service packages

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$ View the [build log](https://storage.cloud.google.com/ci-vcr-logs/beta/refs/heads/auto-pr-10517/artifacts/c70ab88d-38e3-423d-b768-76220c7a08b5/build-log/replaying_test.log)

May 13 '24 11:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 20 insertions(+), 28 deletions(-)) google-beta provider: Diff ( 2 files changed, 20 insertions(+), 28 deletions(-))

May 13 '24 11:05 modular-magician

Tests analytics

Total tests: 3652 Passed tests: 3279 Skipped tests: 371 Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

May 13 '24 12:05 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccCloudFunctionsFunction_firestore[Error message] [Debug log] TestAccDefaultUniverseDomain_doesNotMatchExplicit[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

May 13 '24 12:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 23 insertions(+), 28 deletions(-)) google-beta provider: Diff ( 3 files changed, 23 insertions(+), 28 deletions(-))

May 13 '24 12:05 modular-magician

Tests analytics

Total tests: 3652 Passed tests: 3279 Skipped tests: 372 Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

May 13 '24 14:05 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccCloudFunctionsFunction_firestore[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

May 13 '24 14:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-)) google-beta provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-))

May 16 '24 14:05 modular-magician

Tests analytics

Total tests: 3655 Passed tests: 3284 Skipped tests: 371 Affected tests: 0

Click here to see the affected service packages

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log

May 16 '24 15:05 modular-magician

/gcbrun

May 17 '24 17:05 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-)) google-beta provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-))

May 17 '24 17:05 modular-magician

Tests analytics

Total tests: 3665 Passed tests: 3290 Skipped tests: 371 Affected tests: 4

Click here to see the affected service packages

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

May 17 '24 18:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccDatastreamConnectionProfile_datastreamConnectionProfileBasicExample[Debug log] TestAccDatastreamConnectionProfile_datastreamConnectionProfileFullExample[Debug log] TestAccDatastreamPrivateConnection_datastreamPrivateConnectionFullExample[Debug log] TestAccMonitoringUptimeCheckConfig_noProjectId[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

May 17 '24 19:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-)) google-beta provider: Diff ( 2 files changed, 61 insertions(+), 43 deletions(-))

May 17 '24 19:05 modular-magician

Tests analytics

Total tests: 3669 Passed tests: 3297 Skipped tests: 371 Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

May 17 '24 20:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

May 17 '24 21:05 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 62 insertions(+), 43 deletions(-)) google-beta provider: Diff ( 2 files changed, 62 insertions(+), 43 deletions(-))

May 17 '24 21:05 modular-magician

Tests analytics

Total tests: 3670 Passed tests: 3297 Skipped tests: 372 Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

May 17 '24 22:05 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$ View the build log or the debug log for each test

May 17 '24 23:05 modular-magician