localllm icon indicating copy to clipboard operation
localllm copied to clipboard

fix: model name should be set

Open RealHurrison opened this issue 2 years ago • 3 comments

RealHurrison avatar Apr 23 '24 22:04 RealHurrison

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 23 '24 22:04 google-cla[bot]

Interesting, I'm not sure that the string being used as the model name will make sense to the chat completion API - and the endpoint afaik would only be hosting one model anyway 🤔 I'm curious what will happen when this is set though

im also wondering if we could remove that argument entirely instead

bobcatfish avatar Apr 25 '24 16:04 bobcatfish

/gcbrun

bobcatfish avatar Apr 25 '24 16:04 bobcatfish