community icon indicating copy to clipboard operation
community copied to clipboard

Add Google Cloud Run / Cloudflare tutorial

Open eblaauw opened this issue 4 years ago • 7 comments

eblaauw avatar Jul 15 '21 07:07 eblaauw

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 15 '21 07:07 google-cla[bot]

@googlebot I signed it!

eblaauw avatar Jul 15 '21 07:07 eblaauw

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Jul 15 '21 07:07 google-cla[bot]

Hi @ToddKopriva, hope you are well. I am getting the following test errror:

AssertionError [ERR_ASSERTION]: description should be of the form /^[a-zA-Z0-9\s.,\-()&#'"\/!]+\.$/. but I do not see how my description does not match. Would you mind helping me out?

If you prefer to talk about this on email, we have a dedicated TAM for Delivery Hero, Mario Heyer. He is aware of this and can connect us if you prefer.

eblaauw avatar Jul 15 '21 14:07 eblaauw

Hi @ToddKopriva, hope you are well. I am getting the following test errror:

AssertionError [ERR_ASSERTION]: description should be of the form /^[a-zA-Z0-9\s.,\-()&#'"\/!]+\.$/. but I do not see how my description does not match. Would you mind helping me out?

The description was missing the end punctuation.

Don't worry about that. I'll make sure that it passes when I do my review.

ToddKopriva avatar Jul 15 '21 14:07 ToddKopriva

Hey @ToddKopriva, I hope you are doing well.

Do you have any update on this? Can I help with anything?

eblaauw avatar Aug 12 '21 11:08 eblaauw

Do you have any update on this? Can I help with anything?

I'll be doing this review soon. Sorry for the delay. No, there's nothing that you need to do at this time.

ToddKopriva avatar Aug 12 '21 14:08 ToddKopriva

@eblaauw , I'm sorry about the delay. Is this pull request still current? I'm ready to begin review on it, but I'm concerned that it might be outdated at this point. Just let me know, and I'll begin the review soon after I've received confirmation from you that you want to go forward with this PR and that it's up to date.

ToddKopriva avatar Nov 07 '22 18:11 ToddKopriva

Hi @ToddKopriva, no worries! It is — but let me double check everything tomorrow and update where needed. I will confirm once that’s done.

eblaauw avatar Nov 07 '22 18:11 eblaauw

Thanks.

ToddKopriva avatar Nov 07 '22 19:11 ToddKopriva

@ToddKopriva It should be good to review now. I made a small change when it comes to how to set up an SSL from Cloudflare.

eblaauw avatar Nov 08 '22 08:11 eblaauw

Thanks.

ToddKopriva avatar Nov 08 '22 16:11 ToddKopriva

This publishing system is being shut down and is no longer accepting pull requests for new documents. Documents that have previously been published through this system are being moved to the /archived folder of this repository and are no longer being maintained.

ToddKopriva avatar Jul 29 '23 22:07 ToddKopriva