cloud-opensource-java icon indicating copy to clipboard operation
cloud-opensource-java copied to clipboard

Potential false negatives on protected methods referenced from child class

Open suztomo opened this issue 4 years ago • 0 comments

https://github.com/GoogleCloudPlatform/cloud-opensource-java/pull/2183#discussion_r688009905 found an interesting case where Linkage Checker cannot report linkage errors for protected methods that are referenced from a child class. For example, the code below shows red for compilation error but Linkage Checker would not detect it if the relationship is in a class files.

Screen Shot 2021-08-12 at 16 18 25

This implies that when

  • a method in a library is changing its accessor from public to protected, and
  • the caller and callee has child-parent class relationship

Linkage Checker would fail to report the linkage errors. It considers that a protected method is ok to be accessed by child classes.

I'm not sure how to fix it but I think it's worth document here.

suztomo avatar Aug 12 '21 20:08 suztomo