cloud-code-samples icon indicating copy to clipboard operation
cloud-code-samples copied to clipboard

Upgrade the java-cloud-run-hello-world to the latest version of spring-cloud-gcp-dependencies

Open gustavostz opened this issue 3 years ago • 1 comments

On January 30th, a new version of spring-cloud-gcp, version 4.0.0, was released. This pull request aims to upgrade to this version and make any necessary changes to comply with breaking changes.

For instance, the groupId for spring-cloud-gcp-starter-logging has been changed and the logback-spring.xml file has been adjusted to follow the guidelines at https://logback.qos.ch/codes.html#appender_order to ensure the code works properly. Additionally, the tests have been updated to work with the new version.

P.S. Spring was upgraded too in this PR to work better with the new version of spring-cloud-gcp (https://googlecloudplatform.github.io/spring-cloud-gcp/reference/html/index.html#getting-started):

spring-cloud-gcp compatibility with Spring Project Versions

gustavostz avatar Feb 01 '23 22:02 gustavostz

Due to a validation issue with "Java-Cloud-Run-Hello-World (cloud-code-samples)" validation I am letting this PR stand as a draft. It is quite difficult to determine what is causing this break because I don't have access to the pipeline logs, so I will leave this in this way. However, if you run the Maven install with this PR, it will work and pass all tests.

gustavostz avatar Feb 02 '23 01:02 gustavostz