bigquery-utils icon indicating copy to clipboard operation
bigquery-utils copied to clipboard
verified publisher icon GoogleCloudPlatform

fixes jaccard bug

Open afleisc opened this issue 1 year ago • 3 comments

Closes #383

afleisc avatar May 29 '24 20:05 afleisc 

const la = (sa.length > sb.length) ? sa.length : sb.length
const lb = (sa.length > sb.length) ? sb.length : sa.length

was added as an optimization to the double for loop but introduces a bug.

The incorrect loop limits could cause the intersection count (intersectSize) to be inaccurate, as not all possible character pairs were being compared.

afleisc avatar May 29 '24 21:05 afleisc

/gcbrun

afleisc avatar Jun 10 '24 19:06 afleisc

Sorry just getting to this, can you pull the latest to resolve merge conflicts

danieldeleo avatar Aug 15 '24 00:08 danieldeleo

/gcbrun

afleisc avatar Sep 18 '24 15:09 afleisc