ndb.key.urlsafe() should return a string not bytes #71

[martin-green]

Fixes #71

• [x] Tests pass

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[ludoch]

Hi, Thanks for the PR. Can you update the missing CLA step?

[martin-green]

Done

Den 2023-03-28 kl. 20:37, skrev Ludovic Champenois:

Hi, Thanks for the PR. Can you update the missing CLA step?

— Reply to this email directly, view it on GitHub https://github.com/GoogleCloudPlatform/appengine-python-standard/pull/72#issuecomment-1487423704, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY3SJK3QSUKDPXEG7O5MLDW6MVWPANCNFSM6AAAAAAV7RNG74. You are receiving this because you authored the thread.Message ID: @.***>

[kamilturek]

Hey @ludoch, is there any update on this? I am curious about this change as it would mean drifting away from the Cloud NDB behaviour (which also returns bytes).

https://github.com/googleapis/python-ndb/blob/main/MIGRATION_NOTES.md#:~:text=Key.urlsafe%20outputs,in%20NDB%20behavior.

[shreejad]

Please refer to https://github.com/GoogleCloudPlatform/appengine-python-standard/issues/71#issuecomment-1599355090

TL;DR: This is a breaking change and will create divergent behaviors with Cloud NDB, who also choose to return bytes.