appengine-php-sdk icon indicating copy to clipboard operation
appengine-php-sdk copied to clipboard
verified publisher icon GoogleCloudPlatform

PHP 8.2 dynamic property warning

Open javiermarinros opened this issue 2 years ago • 2 comments

Under PHP 8.2 runtime this notice is emitted

Creation of dynamic property google\appengine\ext\remote_api\Request::$request_id is deprecated in \vendor\google\appengine-php-sdk\src\Ext\RemoteApi\remote_api_pb.php:80

Some more information about PHP 8.2 dynamic properties: https://php.watch/versions/8.2/dynamic-properties-deprecated

javiermarinros avatar Apr 14 '23 14:04 javiermarinros

Just adding extends \stdClass to class \google\net\ProtocolMessage solves the issue and its compatible with older PHP versions.

We need this fix in order to be able to use the SDK in the new PHP 8.2 runtime for AppEngine Standard

@jinglundong

javiermarinros avatar Apr 21 '23 11:04 javiermarinros

Ludo, I think we need to reserve (or request additional) capacity for the PHP SDK repo. I'm a bit overloaded at this point.

jinglundong avatar Apr 26 '23 23:04 jinglundong