DataflowTemplates icon indicating copy to clipboard operation
DataflowTemplates copied to clipboard

Added new templates for PubsubAvroToBigtable and PubsubProtoToBigtable

Open Vasu7052 opened this issue 3 years ago • 12 comments

Hi Team,

Added new v2 templates for streaming real-time binary data from Pub/Sub Subscription to a Bigtable table. I have added support for two Serialization formats which are Avro and Protobuf. Both of them have separate templates.

Vasu7052 avatar Sep 06 '22 08:09 Vasu7052

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 06 '22 08:09 google-cla[bot]

@Vasu7052 Thanks for the contribution! Are you interested in getting this reviewed? The next step would be signing the Contributor License Agreement (CLA) as commented above.

bvolpato avatar Sep 12 '22 04:09 bvolpato

Hey @bvolpato. I've signed the CLA as you mentioned and the scan is reflecting the same. Please guide me through the next steps.

Vasu7052 avatar Sep 12 '22 05:09 Vasu7052

R: @zhoufek

Vasu7052 avatar Sep 15 '22 10:09 Vasu7052

@Vasu7052 Thanks for the contribution! It is looking solid -- I've added a few suggestions based on a quick review. Let me know if you have any questions.

(I will leave for others to comment more on the Bigtable specifics.)

cc @Polber

@bvolpato I've tried resolving your suggestions. do tell me if I miss anything or if any further changes is required.

Vasu7052 avatar Sep 16 '22 11:09 Vasu7052

@bvolpato just a gentle reminder that is there any change required from my end or we can close this PR?

Vasu7052 avatar Sep 28 '22 08:09 Vasu7052

@bvolpato just a gentle reminder that is there any change required from my end or we can close this PR?

Hi @Vasu7052 - thanks again for contributing. It seems good from a quick glance, but I still need some time to look at it carefully (Tentative is still this week).

bvolpato avatar Oct 05 '22 03:10 bvolpato

@bvolpato apologies for bothering you again, but is there anything left for this PR on my side?

Vasu7052 avatar Oct 20 '22 05:10 Vasu7052

@bvolpato can you please tell me the blocker in merging this PR?

Vasu7052 avatar Dec 13 '22 12:12 Vasu7052

Sorry, this wasn't forgotten - we were in the middle of some large changes for templates. The templates now require metadata annotations so we can release them properly when contributed externally: https://github.com/GoogleCloudPlatform/DataflowTemplates#metadata-annotations

Do you want to add such annotations on the templates? I can also help if you prefer. I believe https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/pubsub-binary-to-bigquery/src/main/java/com/google/cloud/teleport/v2/templates/PubsubAvroToBigQuery.java and https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/main/v2/pubsub-binary-to-bigquery/src/main/java/com/google/cloud/teleport/v2/templates/PubsubProtoToBigQuery.java should still serve as examples.

bvolpato avatar Feb 06 '23 03:02 bvolpato

Sure @bvolpato , I'll do the needful changes.

Vasu7052 avatar Feb 06 '23 05:02 Vasu7052

@bvolpato i've tried adding annotations to the required classes, can you please check and do let me know if anything required from my end.

Vasu7052 avatar Mar 08 '23 20:03 Vasu7052

This pull request has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time. Thank you for your contributions.

github-actions[bot] avatar May 25 '24 02:05 github-actions[bot]

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

github-actions[bot] avatar Jun 01 '24 02:06 github-actions[bot]