GoogleCloudPlatform
ElasticsearchIO template improvements
switch create to index to allow duplicates (due to timeout/retry) to not cause errors + add javascript functions for extraction of id, index, type, and whether or not to delete (already supported by ElasticsearchIO)
Resolves #388 Resolves #408
@an2x thanks Nick for the review and approval! I noticed the 2 failed checks but they both seem to be based on code in the main branch that hasn't changed as part of this PR. Will the prevent merging of this PR?
@an2x thanks Nick for the review and approval! I noticed the 2 failed checks but they both seem to be based on code in the main branch that hasn't changed as part of this PR. Will the prevent merging of this PR?
No, it won't.
@ggprod Sounds like mvn spotless:apply should fix the validation for ValueExtractorTransform.java. Did you give it a try?
@ggprod Sounds like
mvn spotless:applyshould fix the validation for ValueExtractorTransform.java. Did you give it a try?
I don't believe there were any spotless problems with ValueExtractorTransform.java. Did you see some somewhere? I did run mvn spotless:apply but found it fixed many issues in other files on the main branch that weren't touched by me
@ggprod Sounds like
mvn spotless:applyshould fix the validation for ValueExtractorTransform.java. Did you give it a try?I don't believe there were any spotless problems with ValueExtractorTransform.java. Did you see some somewhere? I did run mvn spotless:apply but found it fixed many issues in other files on the main branch that weren't touched by me
You got to do it within the v2 module, or if you are in the root: mvn spotless:apply -f v2. v2 is not currently a module from the parent project
@an2x apologies Nick, I had just noticed today there was a minor issue with the README.md files for the Bigquery and GCS Elasticsearch templates so made a small commit to fix those (adding the apiKey to the list of required parameters and updating the Bigquery template to make the table parameter optional, since it could be replaced with the query parameter)
@ggprod Sounds like
mvn spotless:applyshould fix the validation for ValueExtractorTransform.java. Did you give it a try?I don't believe there were any spotless problems with ValueExtractorTransform.java. Did you see some somewhere? I did run mvn spotless:apply but found it fixed many issues in other files on the main branch that weren't touched by me
You got to do it within the v2 module, or if you are in the root:
mvn spotless:apply -f v2. v2 is not currently a module from the parent project
@bvolpato Ok, I ran spotless:apply in the v2 folder. Most of the changes were for files not touced as part of this PR and I did not commit those changes but discarded them. There were a few minor updates to some of the files modified in this PR and I kept and committed those (most recent commit)