quicklink icon indicating copy to clipboard operation
quicklink copied to clipboard

Prerendering is not working

Open kireerik opened this issue 2 years ago • 5 comments

and (when enabled) there is no prefetching either.

example:

  To Reproduce

Enable the option around this line:

  Version:

  • OS w/ version: Windows 10
  • Browser w/ version: Google Chrome 114.0.5735.110

kireerik avatar Jun 17 '23 13:06 kireerik

Thanks for the details @kireerik.

I added the prerenderAndPrefetch option to example/index/index/site/index/main.js#L10

image

and it looks like the resume page is still prefetched as expected, speculation rules is injected and the page is prerendered:

image

Just a side note that the latest quicklink release has not included the update to remove 1 prerender limit, hence the resume page is not included in the speculation rules.

Did you try with prerenderAndPrefetch or any other option to enable prerendering mode?

hadyan avatar Jun 19 '23 14:06 hadyan

I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

Can you release

  • #348

?

kireerik avatar Jun 20 '23 19:06 kireerik

performance.getEntriesByType('navigation')[0].activationStart is 0 (related article section: https://developer.chrome.com/blog/prerender-pages/#detecting-prerender-in-javascript)

kireerik avatar Jun 20 '23 19:06 kireerik

I tried the prerender option. Now I see that the script is added in that case as well. However it seems like the (added) page is not prerendered.

@kireerik Great to see that the prerender option works to add the speculation rules on your page. Which tool did you use to observe whether the page is prerendered successfully. This new preloading panel in DevTools and testing it in Canary will be the most reliable way to test.

Can you release

?

As for the release, hope it can be released soon too. @XhmikosR / @addyosmani have you planned for the next release yet? Thank you!

hadyan avatar Jul 03 '23 07:07 hadyan

@hadyan: IIRC, @addyosmani wanted to make the next version a minor release (I personally would land any other breaking changes and make it v3.0.0 to be safe since the dist file filenames have changed IIRC).

I don't have push rights on npm AFAICT so it's up to @addyosmani to cut the new version :)

XhmikosR avatar Aug 14 '23 16:08 XhmikosR