bubblewrap icon indicating copy to clipboard operation
bubblewrap copied to clipboard

Separating project generation into @bubblewrap/core

Open a13xb opened this issue 4 years ago • 2 comments

The use case is using a Bubblewrap-generated project with a different build system (not Gradle).

Currently a big part of project generation resides in Gradle (resources, some manifest values, shortcuts), so you need an additional build step to finish creating a project usable with another build system, which makes it necessary to have JDK and Android SDK available at project generation time.

The resource files and Android manifest could be templated with lodash directly, bypassing Gradle. Is this something you'd be open to?

a13xb avatar Apr 18 '21 05:04 a13xb

I'll leave Andre to comment on how open he is to this, but out of curiosity, why do you not want to use gradle?

PEConn avatar Apr 20 '21 09:04 PEConn

The resource files and Android manifest could be templated with lodash directly, bypassing Gradle. Is this something you'd be open to?

I'd be open to this without problems.

A bit of context: The reason we have most of the configuration on the Gradle file is mainly historical, and due to the template project being based on the svgomg template, which was supposed to be updated manually and having all the details in the same place made it easy.

One of the upside of this is being able to implement tests for the shortcuts xml generation, which is currently implemented in the Gradle file. It also removes one level of indirection, which would make end-to-end tests better (even tough we don't have those yet).

andreban avatar Apr 20 '21 10:04 andreban