web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Fix Learn PWA stale while revalidate example

Open kabalage opened this issue 3 years ago • 2 comments

The code in this example does not work: Learn PWA! > 008 Serving > Stale while revalidate, because the networkFetch promise does not resolve to a Response.

I fixed the example matching the promise chaining style that's used in the rest of the document. (An async/await version would be nicer though.)

kabalage avatar Oct 18 '22 08:10 kabalage

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 18 '22 08:10 google-cla[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To prevent this from happening, leave a comment.

stale[bot] avatar Jan 17 '23 01:01 stale[bot]