web.dev icon indicating copy to clipboard operation
web.dev copied to clipboard

Remove experimental items from Manifest article

Open jpmedley opened this issue 3 years ago β€’ 3 comments

The article contained information that is still experimental and is behind a flag in Chrome. I'm working on an update to an article that covers the removed items.

jpmedley avatar Aug 10 '22 21:08 jpmedley

Deploy Preview for web-dev-staging ready!

Name Link
Latest commit d87b60d107e74c1a165bd81e674885c442c11ef7
Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/62f42088cb492b0009d4b41f
Deploy Preview https://deploy-preview-8498--web-dev-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 10 '22 21:08 netlify[bot]

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/progressive-web-apps/add-manifest/index.md

  • This file passed all of our automated Markdown audits.

They should not be on MDN because they're still behind a flag. (I hope it wasn't me.) I'll check about when these might be shipping by default, but I may need to take them down from MDN as well.

These are in the new article draft I wrote for richer installs.

jpmedley avatar Aug 11 '22 15:08 jpmedley

Those items are neither behind a flag, nor experimental anymore. They are supported in stable channel on Chrome for Android and soonℒ️ on Desktop.

Regarding a new article, we already have https://developer.chrome.com/blog/richer-pwa-installation/. Why is another required?

I wished @jpmedley would have been pinged about this as I was the one authoring this part of the article.

beaufortfrancois avatar Aug 12 '22 11:08 beaufortfrancois

It's technically an update because new members are being added to screenshots. Rewriting seemed like the better approach, but I realize that I misunderstood the current state.

jpmedley avatar Aug 12 '22 14:08 jpmedley

@jpmedley I'd suggest we add platform to this article and explain it is supported only in Chrome 106 for now.

beaufortfrancois avatar Aug 16 '22 06:08 beaufortfrancois

I agree, except that we can't have experimental features on web.dev any more.

Closing this PR because there's nothing I can do to it right now.

jpmedley avatar Aug 16 '22 13:08 jpmedley

As @tomayac said, the platform member is not experimental. It is standardised: https://www.w3.org/TR/manifest-app-info/#platform-member

I believe we should document it in web.dev.

beaufortfrancois avatar Aug 16 '22 18:08 beaufortfrancois

@jpmedley Do you have plans to update this web.dev article once dcc article is live? If not, I'll do it.

beaufortfrancois avatar Aug 29 '22 07:08 beaufortfrancois

I do. Thank you for the offer.

jpmedley avatar Aug 29 '22 14:08 jpmedley

@jpmedley What is the current status?

beaufortfrancois avatar Sep 12 '22 07:09 beaufortfrancois

I closed this PR because I was misinformed when I opened it.

jpmedley avatar Sep 12 '22 15:09 jpmedley

Sorry. I meant about https://github.com/GoogleChrome/web.dev/pull/8498#issuecomment-1229901381

beaufortfrancois avatar Sep 12 '22 15:09 beaufortfrancois

@beaufortfrancois I'm taking over the article from @jpmedley I'll sync with you tomorrow

tropicadri avatar Sep 12 '22 16:09 tropicadri