GoodDAPP icon indicating copy to clipboard operation
GoodDAPP copied to clipboard

Login link

Open johnsmith-gooddollar opened this issue 3 years ago • 2 comments

Login link

  • [ ] create a separate package "LoginSDK" that handles login link creation/parsing
  • [ ] add a method to generate the link. it has the form of "https://wallet.gooddollar.org/loginwith/?login=" + encoded request
    • [ ] the encoded request is a json object encoded with base64 and encodeURIComponent
    • [ ] the request object has the following fields
      • v: string - name of the vendor
      • web: url - vendor url
      • id: string - vendor whitelisted G$ address
      • cbu: url - callback url
      • rdu: url - redirect url
      • r: array - an array with extra user information fields requested (ie mobile,location,email,avatar,name)
  • [ ] add a method to parse a payment link and return an object/class with long field names (ie vendor for v etc..)
  • see share/index.js in GoodDAPP for similar link handling example
  • [ ] unit tests

johnsmith-gooddollar avatar Jun 15 '22 09:06 johnsmith-gooddollar

@johnsmith-gooddollar wasnt this done as part of the bounty?

sirpy avatar Jun 15 '22 19:06 sirpy

@sirpy this is related to the SDK library. @harjaapdhillon16 implemented it too, but this is out of scope of the PR i've reviewed. I linked his PR to the 'wallet changes' task, as it adds new redirect route, confirmation screen, response handling and other features descrined there

johnsmith-gooddollar avatar Jun 16 '22 09:06 johnsmith-gooddollar