godex
godex copied to clipboard
Resolving build errors on latest Godot[11abffb]/Godex build
Hi,
Several changes have been made to Godot main branch and has resulted in some build errors.
Windows MSVC with debug & release_debug configuration using: Godex Commit: https://github.com/GodotECS/godex/commit/2186bd38900ffba677e51d9ec84944ee64e4a1cc Godot Commit: https://github.com/godotengine/godot/commit/11abffbf1282d457f966741f14aa5a5793f3c208
Issues are;
- Several objects where using a deprecated parameter with 'Object::Connect'. This has to do with this Godot commit: https://github.com/godotengine/godot/commit/d4433ae6d3a525683ef37ea521d30b6b97a44024 The objects that do want a binding should be using 'Callable::Bind' instead. (Note: Functionality should not have changed, but it might be worth to test it.)
- In ''editor_world_ecs.cpp", VSeparator and HSeparator weren't defined, which is likely due to some changes in the Godot includes. (I did not investigate this further.)
- There were linker errors due to inclusion of a translation unit resulting in multiple defined symbols in the linking process. I am unsure if this intended in commit: https://github.com/GodotECS/godex/commit/cf8d204be8d0fbd573b13ae3d348d029af7e803b#diff-c6cc11c18a29769a7d7c241946c0fc4715cb315a87627200b04e47dbfbd7da00
See the pull-request for the fixes.