pyrdp icon indicating copy to clipboard operation
pyrdp copied to clipboard
verified publisher icon GoSecure

Don't log RDP Error Info for client disconnection as error

Open xshill opened this issue 5 years ago • 1 comments

We currently log RDP Error Info PDUs where the description is "The disconnection was initiated by an administrative tool on the server running in the user's session." as errors. They should be logged as informational to notify the MITM user that the client disconnected.

xshill avatar Jan 22 '21 18:01 xshill

Actually this should already be the case, so I'm not sure why we got an error log for that :thinking:

https://github.com/GoSecure/pyrdp/blob/cadee4db847c7c7c5a444070c4f385887655ac03/pyrdp/logging/observers.py#L117-L120

I guess we'll wait to see if this error happens again, so far I can only find one instance in the logs.

xshill avatar Jan 26 '21 19:01 xshill