pyrdp icon indicating copy to clipboard operation
pyrdp copied to clipboard

*Improvement* Auto-close live view of disconnected clients

Open DeadmanLabs opened this issue 6 years ago • 3 comments

Port scanners leave a closed session in the live view of the player so a feature should be added to remove those sessions as they are not live anymore. If some wish to keep these sessions open after they close, then why not auto-open the replay file?

DeadmanLabs avatar Aug 07 '19 19:08 DeadmanLabs

You're right that getting scanned opens a lot of tabs, which can be annoying. Auto-closing would help, but we still need a way to know that a connection happened (from the pyrdp-player) so we can look at the replay files. Definitely something could be done here!

Pourliver avatar Aug 13 '19 13:08 Pourliver

I think I implemented something so that port scans dont make a replay file. If they leave a tab open, it can indeed be confusing and frustrating. I'm unsure right now what is the best way to implement that, but it would indeed be a welcome change.

Res260 avatar Aug 13 '19 23:08 Res260

I would auto-close all "trash" connections that do not complete the connection sequence within a set amount of time. For the purpose of the live tabs, this could be considered as the first frame buffer update to avoid requiring too much refactoring. That should reduce the noise by a significant amount.

Auto-closing of tabs with actual user input would have to be an opt-in setting as it can be confusing, especially if you're watching the tab and it closes on you abruptly. Another QoL thing we could do is maybe "move" the disconnected tabs to the replay pane after some time passes.

alxbl avatar Apr 08 '20 17:04 alxbl