Check boxes don’t toggle correctly

[drewcassidy]

Tapping an empty checkbox in an issue adds extra brackets and removes the dash, and is no longer recognized as a checkbox by github

Using the latest GitHawk beta, version 1.28.0

Bug Report Dump (Auto-generated)

Version 1.28.0 (1554002345)
Device: iPhone 8 (iOS 12.2)
TestFlight: true

[tooomm]

Had the same problem before: https://github.com/GitHawkApp/GitHawk/issues/2655

[BasThomas]

@drewcassidy can you share the markdown of the comment, so we can debug it?

[drewcassidy]

Before:

- [x] Model
- [x] Animate
- [ ] Unwrap
- [ ] Texture
- [ ] Integration
- [ ] QA

After:

- [x] Model
- [x] Animate
[x] ] Unwrap
[x] ] Texture
[x] ] Integration
- [ ] QA

[peterkos]

(If this hasn't been solved yet) Are there any other settings you have in GitHawk? e.g., double-tap reactions. I've found that tapping too quickly on checkboxes triggers the double-tap reaction, which might be a bug on its own and interfere with the checkbox.

Unfortunately I haven't been able to reproduce this either.

Just by looking at the code in IssueCommentSectionController#didTapCheckbox, maybe the checkbox.originalMarkdownRange is somehow being miscalculated, causing the replacement below to be invalid?

let edited = originalMarkdownNSString.replacingCharacters(in: range, with: invertedToken)