GitHawk icon indicating copy to clipboard operation
GitHawk copied to clipboard

Mute and more buttons don't work when a thread is read

Open mesqueeb opened this issue 7 years ago โ€ข 9 comments

GitHawk Upload by mesqueeb

mesqueeb avatar Feb 28 '19 11:02 mesqueeb

I'll take a look at this if no one has started on it yet

RJ-Clegg avatar Feb 28 '19 19:02 RJ-Clegg

@RJ-Clegg How it going?

  • It's often I mark a thread as "read" by mistake, try to mark it "unread" again, but can't because of this bug.
  • Another case I often have is I mark a thread "read", then try to turn off notifications, but cannot do that because of this bug.

I feel a looooot of people would be really excited for your fix! ๐Ÿ’˜๐ŸŽ‰

mesqueeb avatar Mar 11 '19 01:03 mesqueeb

Hi, is there an update on this?

Sent with GitHawk

albertbass86 avatar Mar 28 '19 12:03 albertbass86

I think not yet, it's still bugged in my version ๐Ÿ˜”very annoying but it's a free app so I won't complain? ๐Ÿ˜

Sent with GitHawk

mesqueeb avatar Mar 28 '19 14:03 mesqueeb

Well I ask because I would like to contribute to the project and seemed like this would be a good issue to work on. However it looks like @RJ-Clegg was working on it?

I donโ€™t understand how issue assignment works here.

albertbass86 avatar Mar 28 '19 16:03 albertbass86

Itโ€™s a bit tricky as you canโ€™t assign tickets to outside contributors. Feel free to pick it up, @albertbass86, and let us know if we can help!

Sent with GitHawk

BasThomas avatar Mar 28 '19 17:03 BasThomas

Cool! I was wondering if it was fine for me to just pick it. Will give it a try. Thank you ๐Ÿ‘Œ

Sent with GitHawk

albertbass86 avatar Mar 28 '19 17:03 albertbass86

Hi again, I have a simple solution but it feels a bit like a workaround.

It involves just adding a hitTest to the notification cell so touches are captured by the buttons instead of the cell. I feel like there is a different solution but I do not have enough context of the app to be sure.

Do you want me to create a PR and see @BasThomas or do you have pointers towards a different approach?

albertbass86 avatar Mar 29 '19 08:03 albertbass86

Feel free to open a pull request, and we can continue from there.

I think it already uses a hit test rather than being able to tap the buttons in the cell?

BasThomas avatar Mar 29 '19 09:03 BasThomas