GitHawk icon indicating copy to clipboard operation
GitHawk copied to clipboard

Keyboard Shortcuts

Open Sherlouk opened this issue 8 years ago • 13 comments

Should try and closely match GitHub's keyboard shortcuts in the app, the main ones that interest me would be stuff like cmd+b for bold and other markdown shortcuts

https://help.github.com/articles/using-keyboard-shortcuts/ http://nshipster.com/uikeycommand/

Sherlouk avatar Aug 10 '17 19:08 Sherlouk

yessss

BasThomas avatar Aug 10 '17 19:08 BasThomas

Too cool, lets do it!

rnystrom avatar Aug 11 '17 01:08 rnystrom

Proposing as a start with current functionality:

s - Search (as part of #200) n - Go to Notifications cmd+z/x for Undo/Redo (assuming SlackTextViewController can be used with NSUndoManager) cmd+b/i/k for bold/italics/url respectively enter for start reply (??) ~cmd+enter for submit comment~ SlackTextVC seems to already support enter on physical keyboards! l for edit labels ~m for edit milestones~ (Soon) ~a for edit assignee~ (Soon) j/k to move selection up/down at notification level y to mark selection as read

Obviously all this should be context aware

Sherlouk avatar Aug 11 '17 07:08 Sherlouk

And we should check for which ones it would make sense to make them discoverable. Maybe we won't need to add all of them there.

BasThomas avatar Aug 11 '17 12:08 BasThomas

Just a suggestion but shouldn’t search be cmd+f like in pretty much every single other app? Much more discoverable imho.

shaps80 avatar Aug 11 '17 13:08 shaps80

@shaps80 I was deliberating this one, GitHub uses s but most people use cmd+f for find

Not sure 🤔 Will let someone else choose

Sherlouk avatar Aug 11 '17 14:08 Sherlouk

Maybe it should be configurable. Personally when using a keyboard in an APP (not a website) I would expect to hit CMD+F (CTRL+F Windows).

That said, I was unaware of GitHub's S shortcut. So maybe that's why its odd for me.

shaps80 avatar Aug 11 '17 16:08 shaps80

Also up/down arrows to browse lists :)

BasThomas avatar Sep 23 '17 18:09 BasThomas

Will try to start tackling this soon!

BasThomas avatar Oct 25 '17 09:10 BasThomas

Was about to be like welcome to the team 😅 Changing profile pictures should be banned 🙄 Looking forward to this!

Sherlouk avatar Oct 25 '17 09:10 Sherlouk

Thanks for the warm welcome! 😍

BasThomas avatar Oct 25 '17 10:10 BasThomas

⌘+enter to post bug report

Sent with GitHawk

BasThomas avatar Oct 26 '17 19:10 BasThomas

Sorry closed by accident. Reopened until someone else decides what to do with this ;)

shaps80 avatar Jun 22 '20 22:06 shaps80