GideonZ
C128D issue with RETURN key in menus
Issue Description
When navigating in menus, entering a menu using the RETURN key does not work as expected. Pressing RETURN key once does not do anything. Keep holding RETURN key for 5-20 seconds will eventually enter the menu.
Navigating using right arrow key works as expected. Unfortunately to enter popup menu is only possible by pressing the RETURN key.
In BASIC, all keys work as expected. CIA chips tested OK.
Only C64 mode has been used during testing.
The settings is phi1=200ns, phi2=200ns. All other settings are disabled (REU, kernal shadow RAM,...). Tested various combinations already.
Hardware & Firmware Tested
C128D (plastic version) is impacted by the behavior described above.
C128DCR (metal version) is impacted also, but holding enter for up to 3 seconds usually will enter the menu.
Two cartrdigges were tested: Ultimate-II+L and Ultimate-II+L with wifi. Both having latest 3.11a firmware. Both bahaving exactly the same.
Having used both the UII+ for some 5 years now, and the UII+L since before its official introduction, with C128s, I have never ever experienced this particular issue. Return works totally fine to enter directories, start programs (in 64 mode), etc in the UII+(L) user interface.
I maintain C128 Device Manager, and get feedback from litterally hundreds of C128 users with an UII+ or UII+L. That is 128 'flat', 128D, 128DCR, PAL and NTSC users. I'd have expected to hear a lot about this, but I don't. (experience with firmware 3.4 upto current 3.12 test versions). I recall exactly one user (with a 128DCR, NTSC version) having an issue with return seeming to be 'very slightly sluggish'. Like, it feels like having to hold it for 1/10th of a second or so before it registers. Most definitely not many seconds.
That makes me think either the description of this problem is incomplete, or there is a specific issue with your configuration.
I see you submitted a patch, maybe you can explain in your pull request how that patch will help, and what the exact technical issue is it addresses? The return key is part of the normal keyboard matrix, there should be no reason for handling it in a special way.
