Ghostwriter icon indicating copy to clipboard operation
Ghostwriter copied to clipboard

Support for HTML tables in reports

Open inode- opened this issue 3 years ago • 3 comments

In my tests the HTML tables rendered correctly in the HTML web editor are missing in the docx reports.

It seems that the supported tags are limited to the one supported by the editor: https://github.com/GhostManager/Ghostwriter/blob/1b684ddd119feed9891e83b39c9b314b41d086ca/ghostwriter/modules/reportwriter.py#L281

There is a reason for that?

inode- avatar Jul 05 '22 22:07 inode-

Right now you can only make tables using the Jinja2 templating in a report template (like in the sample report). The WYSIWYG will render tables, but the button to insert a table is disabled until Ghostwriter can support them. You can still enter the HTML manually and get a table, of course. That HTML will be ignored because of that list of allowed HTML tags you linked.

Supporting HTML tables might not be too difficult to do. It's been on my list of things to investigate for when we add the feature to write more than just findings inside Ghostwriter. It's one of the remaining things someone might need in the editor for additional sections. I think most other things are supported already since v2 received support for section headers and a myriad of other formatting options.

I'll add tables to the road map. If it's not too difficult, maybe I can sneak it into the road map for Q3. I'm going to be traveling a lot and attending Black Hat USA, so I expect to dive back into more serious development in August.

chrismaddalena avatar Jul 06 '22 20:07 chrismaddalena

Hi Chris, Did you identify if this was an easy thing to implement? I have a colleague who complains a lot the GhostWriter doesn't support findings with tables. Thanks!

felix-caboff avatar Oct 25 '23 09:10 felix-caboff

@felix-caboff There is an open PR for it that needs testing. If there are no issues, it will likely be in the v4.1 release.

chrismaddalena avatar Nov 09 '23 20:11 chrismaddalena

We included HTML tables in v4.1 so I'm marking this as closed 😄

chrismaddalena avatar Apr 10 '24 21:04 chrismaddalena