stream-chat-react icon indicating copy to clipboard operation
stream-chat-react copied to clipboard

bug: peer dependency error with React 16 / React 17

Open MPeloquin opened this issue 2 years ago • 1 comments

Describe the bug

The peer dependencies have "react": "^18.0.0 || ^17.0.0 || ^16.8.0", but if you install it with react 16.8, there will be peer-dependencies issues because of react-markdown 9.0.0 which has "react": ">=18" in its peer-dependencies.

It seems to work at runtime for us locally, but was breaking our tests & build

It is ok to drop support for old React versions, but it should be clear in the peer-dependencies so we don't try to update yet

To Reproduce

Steps to reproduce the behavior:

  1. Have project with React 16
  2. Install latest stream-chat-react
  3. run install
  4. See peer-dependencies issue:
└─┬ stream-chat-react 11.2.1
  └─┬ react-markdown 9.0.1
    └── ✕ unmet peer react@>=18: found 16.14.0

Expected behavior

Peer-dependencies of stream-chat-react should reflect real version needs

Package version

  • stream-chat-react: 11.2.1

Desktop (please complete the following information):

  • OS: macos
  • Browser chrome
  • Version latest

MPeloquin avatar Jan 09 '24 19:01 MPeloquin

@MPeloquin thank you for raising the issue. We will try that the react-markdown lib incorporates wider range for peer deps. We need to keep our libraries up-to-date, but at the same time need to support those that have not migrated to v18 yet. Thank you for understanding.

MartinCupela avatar Jan 10 '24 11:01 MartinCupela

:tada: This issue has been resolved in version 11.23.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stream-ci-bot avatar Aug 05 '24 12:08 stream-ci-bot

:tada: This issue has been resolved in version 12.0.0-rc.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

stream-ci-bot avatar Aug 15 '24 14:08 stream-ci-bot