ScatterWebExtension icon indicating copy to clipboard operation
ScatterWebExtension copied to clipboard

Account can not be imported with https when generate Identity

Open yepp4you opened this issue 7 years ago • 3 comments

If nodeos only supports https, the code below will not get the account information and will not be able to generate the identity. (For security reasons, BP may not support http.)

&The balance is also fixed in http.

https://github.com/EOSEssentials/Scatter/blob/6c380b2bcc2b8b0907686de3b6a7a9b5d6e550f2/src/plugins/defaults/eos.js#L90

yepp4you avatar Jun 04 '18 01:06 yepp4you

wasn't this just so he could use the demo version on his site?

noddyuk avatar Jun 04 '18 15:06 noddyuk

I have proposed a PR to fixed this issue https://github.com/EOSEssentials/Scatter/pull/75

mlockett42 avatar Jun 06 '18 07:06 mlockett42

Though this is technically fixed on the mainnet due to the new endorsed network, this would still fail on proprietary networks which force SSL.

@mlockett42 's PR will likely become a reality sooner or later which adds a protocol to the networks. I just need to check the implications of that across the codebase.

nsjames avatar Jun 15 '18 03:06 nsjames