atlantis icon indicating copy to clipboard operation
atlantis copied to clipboard

fix(components): Fix popover arrow placement location

Open MichaelParadis opened this issue 1 year ago • 2 comments

Motivations

During this PR https://github.com/GetJobber/atlantis/pull/1844 the arrow positioning of the Popover was changed which broke the location of the arrow. These changes were reverted and some spacing was adjusted on the left and top placement to better match the other placements

Screenshots

Undoing the mentioned PR changes (no spacing adjustments)

Left placement (see after screenshot for updates)

image

Top Placement (see after screenshot for updates)

image

Bottom and right placement

image

After with placement adjustments on left and top

Updated Spacing

All popovers with updated spacing on left and top

image

Changes

Added

Changed

Deprecated

Removed

Fixed

  • Fixed Popover arrow locations.

Security

Testing

For testing use this PR for steps of viewing all pop over placements in a single place https://github.com/GetJobber/Jobber/pull/46557


In Atlantis we use Github's built in pull request reviews.

Random photo of Atlantis

MichaelParadis avatar May 17 '24 15:05 MichaelParadis

Deploying atlantis with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0f20d26
Status: ✅  Deploy successful!
Preview URL: https://cf81a9c6.atlantis.pages.dev
Branch Preview URL: https://job-93961-fix-popover.atlantis.pages.dev

View logs

Published Pre-release for 0f20d2680b9b8d18c6d14dcbab9d2b09a2b4c3b9 with versions:

  - @jobber/[email protected]+0f20d268

To install the new version(s) for Web run:

npm install @jobber/[email protected]+0f20d268

github-actions[bot] avatar May 17 '24 15:05 github-actions[bot]

@scotttjob thanks for the callout. I let Chris know before he went on vacation. There are before and after screenshots of the spacing change but with the placement fix.

MichaelParadis avatar May 21 '24 16:05 MichaelParadis