Geotrek-admin icon indicating copy to clipboard operation
Geotrek-admin copied to clipboard
verified publisher icon GeotrekCE

Bump django-tinymce from 3.5.0 to 4.1.0

Open dependabot[bot] opened this issue 1 year ago • 1 comments

Bumps django-tinymce from 3.5.0 to 4.1.0.

Release notes

Sourced from django-tinymce's releases.

4.1.0

What's Changed

New Contributors

Full Changelog: https://github.com/jazzband/django-tinymce/compare/4.0.0...4.1.0

4.0.0

  • Upgrade embedded TinyMCE from 5.10.7 to 6.8.3

The spellchecker plugin is gone (including USE_SPELLCHECKER setting). Use the browser_spellcheck TinyMCE option (activated by default) to enable browser-based spellchecking.

Changelog

Sourced from django-tinymce's changelog.

Changelog #########

This document describes changes between each past release.

4.0.1 (2024-06-21)

  • Upgrade embedded TinyMCE from 6.8.3 to 6.8.4
  • Renamed toolbar elements (namely formatselect is now blocks) to follow TinyMCE 6 renames. Also removed from the docs examples some buttons only available through paid subscriptions (#470).

4.0.0 (2024-03-27)

  • Upgrade embedded TinyMCE from 5.10.7 to 6.8.3

The spellchecker plugin is gone (including USE_SPELLCHECKER setting). Use the browser_spellcheck TinyMCE option (activated by default) to enable browser-based spellchecking.

3.7.1 (2024-02-06)

  • Reintroduce the MANIFEST.in file to properly build the package. Release 3.7.0 on PyPI was unusable (#454).

3.7.0 (2024-02-06)

  • Drop support for Django 2.2, 4.0, and 4.1.
  • Add support for Django 4.2 and 5.0.
  • Drop support for Python 3.7 and add support for Python 3.11 and 3.12.
  • New pyproject.toml replaces the legacy setup.py project config.
  • Use staticfiles storage API to find tinymce location (#420). It was already done in 3.6.0, but had to be reverted in 3.6.1 (see #430).
  • Fixed selector usage for elements with __prefix__ (typically inlines).
  • TINYMCE_JS_ROOT setting has been removed.

3.6.1 (2023-03-20)

  • Fixed a regression by reverting usage of staticfiles to find tinymce location (#420, #430).

3.6.0 (2023-03-18)

  • Upgrade embedded tinyMCE from 5.10.1 to 5.10.7

... (truncated)

Commits
  • dc64876 Prepare release 4.1.0
  • 4c4dd93 Upgraded TinyMCE to 6.8.4
  • d57a92c [pre-commit.ci] pre-commit autoupdate
  • e79415d Refs #470 - Removed buttons from premium plugins in the docs.
  • fb7b263 Refs #470 - Replaced toolbar elements renamed in TinyMCE 6
  • 87648e8 Remove plugin "code" mentioned twice
  • eac5cc3 Upgrade version in pyproject.toml
  • dc270e1 Prepare release 4.0.0
  • 54d64ba Fixes #460 - Remove sourceMappingURL lines from tinymce static files
  • f04e1c8 Migrate from TinyMCE 5 to TinyMCE 6
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Jul 02 '24 02:07 dependabot[bot]

Geotrek-admin    Run #12998

Run Properties:  status check passed Passed #12998  •  git commit dd50a8582f ℹ️: Merge 3b1d5e59d19a93c2ef719208a2cc195ef66fe662 into a1dc88cafb35df77f796595a7bbd...
Project Geotrek-admin
Branch Review refs/pull/4210/merge
Run status status check passed Passed #12998
Run duration 02m 01s
Commit git commit dd50a8582f ℹ️: Merge 3b1d5e59d19a93c2ef719208a2cc195ef66fe662 into a1dc88cafb35df77f796595a7bbd...
Committer dependabot[bot]
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

cypress[bot] avatar Jul 02 '24 02:07 cypress[bot]

@dependabot recreate

submarcos avatar Nov 26 '24 12:11 submarcos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.46%. Comparing base (a1dc88c) to head (3b1d5e5). Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4210   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files         271      271           
  Lines       22181    22181           
=======================================
  Hits        21840    21840           
  Misses        341      341

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 26 '24 12:11 codecov[bot]

:wave: this django-tinymce upgrade also bumps the TinyMCE major version. I don't think we have e2e tests on the TinyMCE form fields and I expect major changes with TinyMCE objects APIs. We should test this in a separate branch before upgrading.

marcantoinedupre avatar Nov 26 '24 13:11 marcantoinedupre

@marcantoinedupre Thank you

I test in local environement

No visual difference with default Tiny mce fields in admin No visual difference with complex flatpage content with pictures but in console:

  • tinymce.min.js:4 Invalid value passed for the newline_behavior option. Must be one of: block, linebreak, invert or default (in config there is empty '' value. change to default ?
  • In previous version, there is console log that says imagetools will be a premium plugin in next version, so we need to disable it. It seems to be tools to resize / shrink / crop image in web ui (https://www.tiny.cloud/docs/tinymce/5/editimage/)

submarcos avatar Nov 29 '24 09:11 submarcos 

* In previous version, there is console log that says imagetools will be a premium plugin in next version, so we need to disable it. It seems to be tools to resize / shrink / crop image in web ui (https://www.tiny.cloud/docs/tinymce/5/editimage/)

The use of image-tools is perhaps a little superfluous, but if it's essential for the community it should be possible to add a library like cropperjs as a replacement.

dtrucs avatar Nov 29 '24 13:11 dtrucs