geonode icon indicating copy to clipboard operation
geonode copied to clipboard

need to remove call to command rebuild_index in tasks.py

Open cesarbenjamindotnet opened this issue 2 years ago • 4 comments

when tasks.py is called, after the execution of manage.py in function migrations() there is a try block that use command rebuild_index, this returns the message 'Type "manage.py help' for usage.", i found that this is a haystack command, but haystack was removed after the add of django 4.2 support

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • [ ] Confirm you have read the contribution guidelines
  • [ ] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • [ ] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • [ ] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • [ ] The issue connected to the PR must have Labels and Milestone assigned
  • [ ] PR for bug fixes and small new features are presented as a single commit
  • [ ] Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • [ ] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • [ ] This PR passes the QA checks: black geonode && flake8 geonode
  • [ ] Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • [ ] Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

cesarbenjamindotnet avatar Feb 02 '24 00:02 cesarbenjamindotnet

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] avatar Feb 02 '24 00:02 cla-bot[bot]

Codecov Report

Merging #11921 (b8c2beb) into master (d52b27e) will increase coverage by 22.01%. The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #11921       +/-   ##
===========================================
+ Coverage   41.33%   63.35%   +22.01%     
===========================================
  Files         865      865               
  Lines       52291    52291               
  Branches     6575     6575               
===========================================
+ Hits        21617    33130    +11513     
+ Misses      29548    17650    -11898     
- Partials     1126     1511      +385     

codecov[bot] avatar Feb 02 '24 01:02 codecov[bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] avatar Feb 03 '24 17:02 cla-bot[bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @cesar-benjamin on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] avatar Feb 05 '24 15:02 cla-bot[bot]