geonode icon indicating copy to clipboard operation
geonode copied to clipboard

[Fixes #10040] Remove auto-generated thumbnail for documents

Open marthamareal opened this issue 3 years ago • 2 comments

References #10040 ## Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • [x] Confirm you have read the contribution guidelines
  • [x] You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • [x] Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • [x] There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • [x] The issue connected to the PR must have Labels and Milestone assigned
  • [x] PR for bug fixes and small new features are presented as a single commit
  • [x] Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • [ ] New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • [ ] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • [ ] This PR passes the QA checks: flake8 geonode
  • [ ] Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • [ ] Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

marthamareal avatar Sep 21 '22 12:09 marthamareal

This pull request introduces 1 alert when merging 4ecb1dbb306bac27fb1852c80ce7795d1a3aa55d into 540024f1b1ca2b42e16e7da3b71f85128b8052b4 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

lgtm-com[bot] avatar Sep 21 '22 12:09 lgtm-com[bot]

Codecov Report

Merging #10045 (cda7db8) into master (540024f) will increase coverage by 0.00%. The diff coverage is 77.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10045   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files         823      824    +1     
  Lines       50533    50510   -23     
  Branches     7767     7760    -7     
=======================================
- Hits        31055    31041   -14     
+ Misses      17796    17794    -2     
+ Partials     1682     1675    -7     

codecov[bot] avatar Sep 21 '22 12:09 codecov[bot]