Gears comments

Results 138 comments of


                                            Gears

Type narrowing in case expressions

All your suggested wording changes have been implemented

Add `bit_array.to_string_utf16` and `to_string_utf32`

How should we handle endianness? We could have an `Endianness` type as the second argument? The other option would be separate functions for big/little endian

Add `bit_array.to_string_utf16` and `to_string_utf32`

For utf-8, each code unit is one byte, so endianness doesn't apply. It only matters for UTF-16 and UTF-32 where code units are more than one byte

Add `bit_array.to_string_utf16` and `to_string_utf32`

I'm not sure. Where I encountered it in ID3, there is always a preceding Byte-Order Mark which denotes the endianness of the encoded text. It's possible that it will be...

Add `bit_array.to_string_utf16` and `to_string_utf32`

That's also possible

Convert variable names to snake_case

Thanks for all the feedback! I know it's quite a big PR, and I'm still pretty new to this codebase. I'll go through and implement these as soon as possible.

Convert variable names to snake_case

I've made some changes: - I've removed `BadNames` from the capnp schema - I've merged the error variants into one and added the `BadNameKind` enum. - I also added a...

Convert variable names to snake_case

Thinking about this more, it might be better to implement `NameChecker` as a struct, which just holds references to the `errors` and `bad_names` vectors.

Convert variable names to snake_case

I've now moved the name checking code into function in `name.rs` inside the `analyse` module

Convert variable names to snake_case

I've now cleaned up everything that you suggested