PyElastica Typing/memory block

Typing for rod and rigid body memory blocks.

May 13 '24 19:05 armantekinalp

Does it pass if you run poetry run mypy --config-file pyproject.toml elastica/memory_block?

May 15 '24 18:05 skim0119

Does it pass if you run poetry run mypy --config-file pyproject.toml elastica/memory_block?

It doesn't because SystemIdxType is not defined. You have defined in PR #382 . We can wait you to merge that.

May 15 '24 18:05 armantekinalp

SystemIdxType is now included in update/mypy branch: https://github.com/GazzolaLab/PyElastica/blob/update/mypy/elastica/typing.py

https://github.com/GazzolaLab/PyElastica/blob/4d05804632fb2839dfcfad7e7c18f1eb180af7e7/elastica/typing.py#L58

May 15 '24 18:05 skim0119

Cool thanks, now it passes

May 15 '24 18:05 armantekinalp

On this PR, can you also include typing for the file elastica/modules/memory_block.py?

May 15 '24 18:05 skim0119

okay will work on that

May 15 '24 18:05 armantekinalp

Also this one: https://github.com/armantekinalp/PyElastica/blob/typing/memory_block/elastica/reset_functions_for_block_structure/_reset_ghost_vector_or_scalar.py

May 15 '24 18:05 skim0119

Also this one: https://github.com/armantekinalp/PyElastica/blob/typing/memory_block/elastica/reset_functions_for_block_structure/_reset_ghost_vector_or_scalar.py

On this PR, can you also include typing for the file elastica/modules/memory_block.py?

@armantekinalp I accidently resolved them on 384

Jun 13 '24 12:06 skim0119