PyElastica icon indicating copy to clipboard operation
PyElastica copied to clipboard

Remove the option for internal damping module for Cosserat rods following warning message

Open bhosale2 opened this issue 3 years ago • 1 comments

Currently, adding damping to the rod via AnalyticalLinearDamper results in the following warning message:

Screen Shot 2022-08-30 at 10 02 31 PM

Per the warning to make a soft change, we should convert the warning message to an error message if the user provides internal damping other than None when initializing a Cosserat rod, and remove related functionality from the cosserat rod equations.

Thoughts @armantekinalp and @skim0119?

bhosale2 avatar Aug 31 '22 03:08 bhosale2

I agree with you suggestion. As we discussed with @bhosale2, I think we should remove the internal damping functionality, all variables and tests as we planned in v.0.3.1 and update the warning message accordingly.

armantekinalp avatar Aug 31 '22 19:08 armantekinalp

Closed via #243.

bhosale2 avatar May 03 '23 22:05 bhosale2