PyElastica icon indicating copy to clipboard operation
PyElastica copied to clipboard

Clarify namespace for elastica modules to avoid namespace confusion and clutter

Open bhosale2 opened this issue 3 years ago • 2 comments

Currently, in example cases, the modules from elastica are imported directly as from elastica import *. This can become an issue when using elastica across packages (where elastica is a plugin), where modules from other packages can collide in namings with the modules from elastica. To avoid this, it may be helpful to use functionalities in elastica as:

import elastica as ea; ea.Damping(....) to make it explicit where the functionality comes from.

@skim0119 and @armantekinalp thoughts?

bhosale2 avatar Aug 30 '22 20:08 bhosale2

I think it is a good suggestion.

armantekinalp avatar Aug 30 '22 21:08 armantekinalp

Last point on pep8

skim0119 avatar Aug 31 '22 05:08 skim0119

Yes it is still open

armantekinalp avatar Feb 08 '23 16:02 armantekinalp

If this issue is still open, I would like to be assigned to it. @armantekinalp @bhosale2

Rahul-JOON avatar Feb 18 '23 20:02 Rahul-JOON

Is this issue is open?? @armantekinalp

Deep-Rai-08 avatar Mar 13 '23 07:03 Deep-Rai-08

@Deep-Rai-08 The issue is still open. Feel free to make a PR.

skim0119 avatar Mar 14 '23 14:03 skim0119

A note to everyone interested in this issue: if you plan to work on it please either assign yourself to the issue or let us know that you wish to be assigned to the issue.

bhosale2 avatar Mar 15 '23 03:03 bhosale2

@bhosale2 NameSpaces can be a great way to sort and clarify the elastica modules Please assign me to this issue

amangupta201 avatar Mar 20 '23 16:03 amangupta201

Hi, is anyone still working on the issue? If not I'd like to work on it. @armantekinalp

AsadNizami avatar Mar 27 '23 07:03 AsadNizami

Closed via #238.

bhosale2 avatar Apr 25 '23 19:04 bhosale2