PyElastica icon indicating copy to clipboard operation
PyElastica copied to clipboard

Separate joint module into separate connections and collision

Open bhosale2 opened this issue 3 years ago • 3 comments

Currently, the implementation for connections and collision lies in joint.py which is a rather non-intuitive name for its contents. A more intuitive name could be connections_and_collision.py? @armantekinalp and @skim0119 suggestions?

bhosale2 avatar Jun 16 '22 15:06 bhosale2

I think collision should be separated. I agree that `connection could be more general name.

skim0119 avatar Jun 17 '22 14:06 skim0119

Ok, then the consensus on this is:

  1. Rename joint.py to connections.py
  2. Move out collision classes into a separate collision.py

bhosale2 avatar Jun 18 '22 16:06 bhosale2

Yes, I think it is a good idea

armantekinalp avatar Jun 18 '22 16:06 armantekinalp

Merging checklist

  • [x] New contact module, Surface base class and tests
  • [x] Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests
  • [x] Surface subclass: plane, and tests
  • [x] Updated rod-plane contact classes (from InteractionPlane and AnistropicFrictionalPlane)
  • [x] Updated rod-plane contact classes tests and refactor contact functions in interaction.py and joint.py
  • [x] Updated rod-plane contact examples
  • [x] Cylinder-plane contact class and tests
  • [x] Contact Module Documentation (#331)

Ali-7800 avatar Jul 17 '23 21:07 Ali-7800

@Ali-7800 added the New Contact module, surface base class, and tests via #281.

Rahul-JOON avatar Aug 08 '23 13:08 Rahul-JOON

Added Updated rod-rod, rod-cylinder, self-contact classes, examples, and tests via #291

Ali-7800 avatar Aug 21 '23 22:08 Ali-7800

Added the new plane surface subclass.

Ali-7800 avatar Oct 27 '23 21:10 Ali-7800

Added updated rod-plane contact class

Ali-7800 avatar Oct 31 '23 02:10 Ali-7800

Updated rod-plane contact classes tests and refactored contact functions in interaction.py and joint.py

Ali-7800 avatar Nov 07 '23 11:11 Ali-7800

Updated rod-plane contact examples and added continuum snake with lifting wave example

Ali-7800 avatar Dec 06 '23 11:12 Ali-7800

Added cylinder-plane contact class

Ali-7800 avatar Feb 13 '24 23:02 Ali-7800

Updated documentation for contact module, closing now as issue is resolved

Ali-7800 avatar Feb 20 '24 19:02 Ali-7800