GM4_Datapacks icon indicating copy to clipboard operation
GM4_Datapacks copied to clipboard

1.21.4 Resource Pack Support

Open SpecialBuilder32 opened this issue 11 months ago • 6 comments

Adds 1.21.4. item model definition files to the resource pack, and moves existing models to an overlay for backwards compatibility.

Remaining tasks:

  • [ ] Testing in-game
  • [x] RP marked valid versions (1.21.3 should not throw warning)
  • [x] Restore backwards compatibility for shamir textures
  • [ ] Fix vanilla item-model forwarding

SpecialBuilder32 avatar Feb 12 '25 03:02 SpecialBuilder32

I'm getting lots of resource pack load errors.

I was almost certain it did support item-model-definition compounds both when I tested it and re the wiki. image I'll do some more digging and see why I didn't get this problem on my end and/or what has changed

SpecialBuilder32 avatar Mar 02 '25 20:03 SpecialBuilder32

@SpecialBuilder32 Have you had time to look further into these issues? Given that 1.21.5-pre1 just released, it would be ideal if this PR is ready to be merged before we have to worry with the 1.21.5 update.

misode avatar Mar 11 '25 19:03 misode

In tracking down what the load errors were, I realized there were some special cases I needed to manually handle. I had thought it was just the end fishing elytra but now that I see build errors I realize armor trims must also be redone :/

SpecialBuilder32 avatar Mar 14 '25 01:03 SpecialBuilder32

Alright just a quick update on this - after running into too many edge cases, I'm half-rewriting the 1.20.4/1.20.5 update to make more sense and handle model-file/item-definition interactions better. It'll be a fair amount of more testing and debugging until this is ready. Sorry 😢

SpecialBuilder32 avatar Apr 24 '25 02:04 SpecialBuilder32

@SpecialBuilder32 With #1107 being merged now, is this PR also good to go?

misode avatar May 25 '25 21:05 misode

For future people reading this: RP support for 1.21.4 is still missing as of today.

Bloo-dev avatar Jul 28 '25 20:07 Bloo-dev