feat(core): move default settings to seperate conf
Description
Move the notification part to a seperate config and prevent users from making changes there.
Fixes #3741
Type of change
- [ ] Bug fix (a change which fixes an issue).
- [x] New feature (change which adds functionality).
- [ ] New Server (new server added).
- [ ] Refactor (restructures existing code).
- [ ] Comment update (typo, spelling, explanation, examples, etc).
Checklist
PR will not be merged until all steps are complete.
- [ ] This pull request links to an issue.
- [ ] This pull request uses the
developbranch as its base. - [ ] This pull request Subject follows the Conventional Commits standard.
- [ ] This code follows the style guidelines of this project.
- [ ] I have performed a self-review of my code.
- [ ] I have checked that this code is commented where required.
- [ ] I have provided a detailed with enough description of this PR.
- [ ] I have checked If documentation needs updating.
Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
- User docs: https://github.com/GameServerManagers/LinuxGSM-Docs
- Dev docs: https://github.com/GameServerManagers/LinuxGSM-Dev-Docs
Thank you for your Pull Request!
I am happy with the idea. I just need to do testing 👍🏻
I am happy with the idea. I just need to do testing 👍🏻
looks like it needs at first a rebase before testing to match the develop branch
Rebased. Another idea for this: Maybe we consider to do this the other way around and use the new one as a inital template and only set the variables in the serverconfig what you need.
Rebased this again to the latest develop branch and added the 2 new added servers to the PR.