LinuxGSM icon indicating copy to clipboard operation
LinuxGSM copied to clipboard

feat(refactor): Add extraparams parameter to all gameservers

Open borzaka opened this issue 7 years ago • 3 comments

Description

Now you can easily add any extra parameter to your gameserver without copying and modifying the whole fn_params() in your instance.cfg

Fixes #2183

Type of change

  • [ ] Bug fix (non breaking change which fixes an issue)
  • [x] New feature (non breaking change which adds functionality)
  • [X] Refactor (non breaking change restructures existing code)
  • [X] This change requires a documentation update

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] This pull request links to an issue
  • [ ] I have performed a self review of my own code
  • [X] I have commented my code, particularly in hard to understand areas
  • [ ] I have made corresponding changes to the documentation

borzaka avatar Dec 15 '18 22:12 borzaka

i have synced the PR with latest develop codebase, it should be ready for testing

Frisasky avatar Jul 11 '19 00:07 Frisasky

Codacy Here is an overview of what got changed by this pull request:


Issues
======
+ Solved 2
- Added 1
           

See the complete overview on Codacy

dgibbs64 avatar Nov 21 '19 15:11 dgibbs64

Score: 0.89

Best reviewed: commit by commit


Optimal code review plan (8 warnings)

Add extraparams parameter to all gameservers

...lgsm/codwawserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/bsserver/_default.cfg 50% changes removed in Merge branch 'develo...

...-lgsm/coduoserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/cod2server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/insserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/q3server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/codserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/rustserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/tuserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/twserver/_default.cfg 50% changes removed in Merge branch 'develo...

...g-lgsm/cod4server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/doiserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/dstserver/_default.cfg 75% changes removed in Merge branch 'develo...

...-lgsm/pstbsserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/ut3server/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/etlserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/boserver/_default.cfg 50% changes removed in Update _default.cfg

...g-lgsm/inssserver/_default.cfg 50% changes removed in Merge branch 'develo...

...ig-lgsm/kf2server/_default.cfg 50% changes removed in Merge branch 'develo...

...lgsm/bt1944server/_default.cfg 50% changes removed in Merge branch 'develo...

...-lgsm/nmrihserver/_default.cfg 50% changes removed in Merge branch 'develo...

...fig-lgsm/pzserver/_default.cfg 67% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

...ctions/install_server_files.sh 40% changes removed in Merge branch 'develo...

...gsm/functions/query_gsquery.py 75% changes removed in Merge branch 'develo...

tests/tests_jc2server.sh 41% changes removed in Merge branch 'develo...

...functions/install_ut2k4_key.sh 50% changes removed in Merge branch 'develo...

tests/tests_ts3server.sh 41% changes removed in Merge branch 'develo...

...functions/check_tmuxception.sh 75% changes removed in Merge branch 'develo...

...gsm/functions/query_gamedig.sh 48% changes removed in Merge branch 'develo...

tests/tests_fctrserver.sh 42% changes removed in Merge branch 'develo...

...tions/command_dev_query_raw.sh 58% changes removed in Merge branch 'develo...

...UE_TEMPLATE/feature_request.md 41% changes removed in Merge branch 'develo...

CONTRIBUTING.md 67% changes removed in Merge branch 'develo...

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

Update _default.cfg

...ig-lgsm/untserver/_default.cfg 50% changes removed in Merge branch 'develo...

     Update _default.cfg

     Update _default.cfg

     Update _default.cfg

Merge branch 'develop' into add-extraparams-parameter

...gsm/functions/info_messages.sh 44% changes removed in Merge branch 'develo...

...gsm/functions/command_debug.sh 50% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

...gsm/functions/command_start.sh 67% changes removed in Merge branch 'develo...

...sm/functions/command_fastdl.sh 67% changes removed in Merge branch 'develo...

linuxgsm.sh 50% changes removed in Merge branch 'develo...

     add extraparams

     add extraparams

     add extraparams

Merge branch 'develop' into add-extraparams-parameter

lgsm/functions/info_distro.sh 41% changes removed in Merge branch 'develo...

...-lgsm/pstbsserver/_default.cfg 67% changes removed in Merge branch 'develo...

lgsm/functions/check_deps.sh 62% changes removed in Merge branch 'develo...

...ig-lgsm/etlserver/_default.cfg 80% changes removed in Merge branch 'develo...

...gsm/functions/query_gamedig.sh 43% changes removed in Merge branch 'develo...

     add extraparams

     add extraparams

Merge branch 'develop' into add-extraparams-parameter

...ons/command_ts3_server_pass.sh 50% changes removed in Merge branch 'develo...

lgsm/functions/mods_core.sh 57% changes removed in Merge branch 'develo...

Merge branch 'develop' into add-extraparams-parameter

lgsm/functions/check_deps.sh 55% changes removed in Merge branch 'develo...

     Update _default.cfg

     Merge branch 'develop' into add-extraparams-parameter

Powered by Pull Assistant. Last update 9c2ce41 ... 42c9f14. Read the comment docs.

pull-assistant[bot] avatar Mar 17 '20 02:03 pull-assistant[bot]