PhotonDCR config bugs

Open jmeyers314 opened this issue 3 years ago • 1 comments

Placing here so I don't forget:

Looks like PhotonDCR._opt_params is missing an entry for obj_coord.

Also, there's a typo: zenit_coord -> zenith_coord.

Need to add some config usage tests.

Apr 25 '22 19:04 jmeyers314

One comment about this. The zenit_coord is of course a typo-bug, which apparently isn't covered by unit tests. But obj_coord is handled by the PhotonDCRBuilder here: https://github.com/GalSim-developers/GalSim/blob/releases/2.3/galsim/config/photon_ops.py#L220

Jun 17 '22 19:06 rmjarvis

Done via #1160

Aug 16 '22 16:08 rmjarvis