Gabriele Picco comments

Results 27 comments of


                                            Gabriele Picco

Add Support for the Digital Asset Standard (DAS) API

Hey @coolestnick, thanks for the interest to work on this. - The issue is to support the DAS api, defined here: https://github.com/metaplex-foundation/digital-asset-standard-api?tab=readme-ov-file#methods An implementation would require: 1. Write a class...

Failed to deserialise Jupiter swap transaction

Can you please post the full snippet to reproduce the issue? Including token mints, amount, etc ... Does the swap you are trying work in the demo: https://magicblock-labs.github.io/Solana.Unity-SDK/ ?

fix: secret ENV variables should be read by forked PR's also

Thanks @iamnamananand996 . LGTM!

refactor: break down the cli application function to specific file

Thanks @iamnamananand996 for the contribution. Separating and simplifying the `lib.rs` and `rust_template.rs` sounds like a good idea. The template system and reading from a .txt add complexity, I would rather...

refactor: break down the cli application function to specific file

@iamnamananand996 the deployment keys should be injected from secret ENV variables by the workflow: https://github.com/magicblock-labs/bolt/blob/main/.github/workflows/run-tests.yml#L142

refactor: break down the cli application function to specific file

Thanks @iamnamananand996. #76 is now merged, rebasing the branch on `main`should eventually solve the CI/CD issue

chnges extra_seed from String to Vec<u8>

Thanks @mubarizkyc . This change requires also modifications in the client SDKs

chnges extra_seed from String to Vec<u8>

Closing as supported in https://github.com/magicblock-labs/bolt/pull/86

[Bug] reduce the SOL cost of deployment

Bundle of components could also be batched under a single program

fix: :bug: Components CPI caller check

@iamnamananand996 the PR looks good to me, but we should enforce that the check is now correct. There are [2 integration tests](https://github.com/magicblock-labs/bolt/blob/main/tests/bolt.ts#L630) for the CPI check that were passing with...