TDA-tutorial icon indicating copy to clipboard operation
TDA-tutorial copied to clipboard

Mapper + GIC tuto

Open MathieuCarriere opened this issue 5 years ago • 1 comments

MathieuCarriere avatar Oct 16 '20 16:10 MathieuCarriere

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

could you specify the lines of code that are causing trouble for your first and third comments? I don't see them

MathieuCarriere avatar Apr 20 '23 15:04 MathieuCarriere

could you specify the lines of code that are causing trouble for your first and third comments? I don't see them

Do you see any "reviewnb" link on this page? If not, maybe you need to connect to it once before that happens?

As an alternative, you could go to the top-right of the page, click on your icon, select "feature preview" and enable "rich jupyter notebook diffs", so that afterwards clicking on "files changed" will show you a nicer diff between notebooks. Sadly, it does not seem to show the comments inline, you need reviewnb for that.

mglisse avatar Apr 20 '23 16:04 mglisse

Thanks, I logged in and saw the reviews.

MathieuCarriere avatar Apr 21 '23 09:04 MathieuCarriere

View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2023-05-22T15:13:04Z ----------------------------------------------------------------

Line #153.            print(str(bootstrap_id) + "th iteration")

Thanks to tqdm, you can now remove this print


View / edit / reply to this conversation on ReviewNB

VincentRouvreau commented on 2023-05-22T15:24:44Z ----------------------------------------------------------------

Line #3.    import gudhi as gd

You can remove this import as not used


Done!

MathieuCarriere avatar May 23 '23 09:05 MathieuCarriere