react-native-magic-modal icon indicating copy to clipboard operation
react-native-magic-modal copied to clipboard

Add portal defaultProps

Open laogui opened this issue 3 years ago β€’ 1 comments

Note: erase all explanatory text from this template, replacing it with your words/images.

πŸ“ DESCRIPTION:

Briefly explain the solution (this will make it easier for the reviewer to confirm that the code does what it should), for example:

  • PR changed this because of that.
  • We are creating this task to address this problem.

πŸ–Ό picture: PRINTS & GIFS:

Include the best screenshots or gifs of the feature if applicable.

(on Macs, ⌘ + ⇧ + 5 is your friend as you can take multiple screenshots/recordings from a fixed window)

πŸ’› MY AMAZING PR CONTAINS:

Does this PR change only one thing (And only what is necessary for it)?
  • if not, then why? (e.g., native changes require bureaucratic releases to app stores)
  • The Boy Scout Rule is encouraged, but always consider impact and scope when following it.
Awesome tests or e2e (avoid shallow rendering)
  • if not, then:
    1. is it a script or configuration file?
    2. something else, and there's a very, very good reason
    • anyway, please explain the situation

laogui avatar Sep 28 '22 10:09 laogui

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟒 Statements 100% 35/35
🟒 Branches 100% 5/5
🟒 Functions 92.31% 12/13
🟒 Lines 100% 69/69

Status of coverage: 🟒 - ok, 🟑 - slightly more than threshold, πŸ”΄ - under the threshold

Report generated by πŸ§ͺjest coverage report action from 3ef8a77c0d3f35a1ab53abec0bfdaf2d5866d23a

github-actions[bot] avatar Sep 28 '22 10:09 github-actions[bot]

Hey, Iaogui! There's no need to pass any props to the MagicModal. We are already extending the styles with the props passed on the magicModal.show method. That leaves enough flexibility to style individual modals any way you prefer.

GSTJ avatar Nov 01 '22 13:11 GSTJ