data.gov icon indicating copy to clipboard operation
data.gov copied to clipboard
verified publisher icon GSA

Reintegrate ckanext-spatial upstream into catalog.data.gov

Open btylerburton opened this issue 3 years ago • 1 comments

User Story

In order to reduce our maintenance burden, Data.gov team wants investigate whether we can reintegrate catalog.data.gov with the upstream version of the ckanext-spatial extension.

Reference:

Acceptance Criteria

[ACs should be clearly demoable/verifiable whenever possible. Try specifying them using BDD.]

  • [ ] GIVEN [a contextual precondition]
    [AND optionally another precondition]
    WHEN [a triggering event] happens
    THEN [a verifiable outcome]
    [AND optionally another verifiable outcome]

Background

[Any helpful contextual notes or links to artifacts/evidence, if needed]

Security Considerations (required)

[Any security concerns that might be implicated in the change. "None" is OK, just be explicit here!]

Sketch

  • [ ] Check if catalog builds and functions correctly with ckanext-spatial upstream.
    • [ ] Reintegrate with upstream.

btylerburton avatar Sep 01 '22 20:09 btylerburton

We should make sure our fork of ckanext-spatial is as up to date as possible. Review recent PR's to see if anything needs to be merged upstream, or any other fixes. One specific item Update Package Schema for Tags will not be merged. We should take out this code and put it in https://github.com/GSA/ckanext-datagovcatalog. And document the crap out of it.

jbrown-xentity avatar Oct 06 '22 20:10 jbrown-xentity

Our customizations:

  • (Old) https://github.com/GSA/ckanext-spatial/pull/9
    • Overwritten by: https://github.com/GSA/ckanext-spatial/pull/10
  • https://github.com/GSA/ckanext-spatial/pull/11
  • https://github.com/GSA/ckanext-spatial/pull/12
  • https://github.com/GSA/ckanext-spatial/pull/14
  • https://github.com/GSA/ckanext-spatial/pull/16

Merged (or at least started) Upstream:

  • https://github.com/ckan/ckanext-spatial/pull/252
  • https://github.com/ckan/ckanext-spatial/pull/278
  • https://github.com/ckan/ckanext-spatial/pull/261

TODO:

  • [x] Move package schema update for tags to different extension

nickumia-reisys avatar Oct 24 '22 12:10 nickumia-reisys

Only one customization is not captured and I believe it is not critical.

  • https://github.com/ckan/ckanext-spatial/pull/261

Can you confirm @jbrown-xentity?

nickumia-reisys avatar Oct 26 '22 15:10 nickumia-reisys

It was determined that the above changes may cause issues, but will be taken care of in a separate ticket.

nickumia-reisys avatar Oct 27 '22 15:10 nickumia-reisys