Logo is added to organization in catalog but does not display on dataset page

[hkdctol]

NCUA was added as an organization to catalog, with a URL for logo: https://www.ncua.gov/files/graphics/ncua_seal_blue_web.gif

How to reproduce

Go to https://catalog.data.gov/dataset/publicly-available-financial-performance-data-for-federally-insured-credit-unions

Expected behavior

Logo should appear on upper left on dataset page

Actual behavior

No logo appears

[jbrown-xentity]

Start with the function get_bureau_info in ckanext-datagovtheme. This is used to render the image on the package page: https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/templates/templates_new/snippets/organization.html#L14-L50 Something is going wrong here with the image url being defaulted too, need to investigate further. Something might have changed in CKAN2.9.

[btylerburton]

@jbrown-xentity what is the process for adding logos to https://github.com/GSA/ckanext-datagovtheme/tree/main/ckanext/datagovtheme/fanstatic_library/images/logos directory? As that's the location get_bureau_info is trying to pull from.

This dataset works, for example: https://catalog.data.gov/dataset/chemical-phytoplankton-zooplankton-benthic-organisms-and-other-data-from-moored-current-me

Because https://catalog.data.gov/images/logos/006-48.png exists

[jbrown-xentity]

If someone wants to add their bureau logo, then we add it (basically on a request basis). In this case, someone setup the organization to have a link to their logo: https://catalog.data.gov/organization/national-credit-union-administration (you can inspect the page to see the image is actually from ncua.gov) The would expect that image to show up on their dataset pages (as is standard on CKAN), but it doesn't: https://catalog.data.gov/dataset/ncua-active-federally-insured-credit-unions-list-59c68 My guess is something changed in the data such that https://github.com/GSA/ckanext-datagovtheme/blob/main/ckanext/datagovtheme/templates/templates_new/snippets/organization.html#L47 doesn't work anymore, maybe the organization data isn't right? Or something else we can't see possibly... We should be able to customize for each bureau, but the default ckan should still work. It looks similar upstream: https://github.com/ckan/ckan/blob/2.9/ckan/templates/snippets/organization.html#L30

[btylerburton]

yeah, for some reason organization.image_display_url is no longer available at the dataset level. just organization.image_url. should have a draft branch up shortly.

[btylerburton]

but the default ckan should still work. It looks similar upstream: https://github.com/ckan/ckan/blob/2.9/ckan/templates/snippets/organization.html#L30

now that's weird and i'm perplexed 😬

[btylerburton]

this looks relevant https://github.com/ckan/ckan/blob/master/ckan/lib/dictization/model_dictize.py#L439

image_url = result_dict.get('image_url')
result_dict['image_display_url'] = image_url

[hkdctol]

Putting back in icebox for now given other priorities

[btylerburton]

https://github.com/GSA/ckanext-datagovtheme/pull/124/files

This PR addressed one part of the problem, however viewing collections did not contain an image_url on the organization object so this did not address the root cause, which was image_display_url not being bubbled up to the dataset level.