gpu_performance_api icon indicating copy to clipboard operation
gpu_performance_api copied to clipboard

GPA is not library friendly

Open chaoticbob opened this issue 6 years ago • 2 comments

GPA usage of CMake is very awkward making it difficult to simply include GPA into an existing large project by setting variables and then calling add_subdirectory. Currently doing so causes the build process to produce binary paths that can't be found.

chaoticbob avatar Mar 03 '19 15:03 chaoticbob

Yes, this isn't a usage model that we considered. We'll take a look to see what can be done to make this experience better.

chesik-amd avatar Mar 05 '19 21:03 chesik-amd

I've just pushed a few changes to the CMake files. WIth these changes, we've been able to include GPA in another project by simply using add_subdirectory. There is still a prerequisite that you'll need to run UpdateCommon.py before doing this. Can you give the latest sources a try and see if it works better for you? If you still run into problems, we may need more info on exactly how you are using this, and what exact problems you still see.

Thanks!

chesik-amd avatar Mar 18 '19 22:03 chesik-amd