RenderPipelineShaders icon indicating copy to clipboard operation
RenderPipelineShaders copied to clipboard
verified publisher icon GPUOpen-LibrariesAndSDKs

Fix RPSL explorer compilation not working on Windows

Open Mcgode opened this issue 2 years ago • 2 comments

The RPSL compilation command does not work on Windows, and seems to have been designed for Unix-like systems.

This PR fixes the command line for Windows, while keeping compatibility with Unix systems. Addresses #28

Mcgode avatar May 06 '23 12:05 Mcgode

I think using the std::filesystem:path functions would be tidier: https://en.cppreference.com/w/cpp/filesystem/path/make_preferred. But I'm not sure what version of c++ RPS is targetting.

expenses avatar May 08 '23 10:05 expenses

Indeed, thanks for the comment.

The RPS lib itself target C++11 but rpsl_explorer.hpp itself uses C++17 (and already uses std::filesystem::path in the same function)

Mcgode avatar May 09 '23 06:05 Mcgode