Common.h is missing a definition needed for hiprtUint2 tea(uint32_t, uint32_t)

[amerus]

I had to add the following definition to Common.h in order to compile successfully for the latest version: #define make_uint2 make_hiprtUint2

Otherwise, make fails with the following error: ==== Building 00_context_creation (debug_x64) ==== Creating obj/x64/Debug/00_context_creation Orochi.cpp OrochiUtils.cpp SceneDemo.cpp In file included from ../../tutorials/common/TutorialBase.h:32, from ../common/SceneDemo.h:25, from ../common/SceneDemo.cpp:23: ../../tutorials/common/Common.h: In function ‘hiprtUint2 tea(uint32_t, uint32_t)’: ../../tutorials/common/Common.h:137:16: error: there are no arguments to ‘make_uint2’ that depend on a template parameter, so a declaration of ‘make_uint2’ must be available [-fpermissive] 137 | return make_uint2( v0, v1 ); | ^~~~~~~~~~ ../../tutorials/common/Common.h:137:16: note: (if you use ‘-fpermissive’, G++ will accept your code, but allowing the use of an undeclared name is deprecated) make[1]: *** [00_context_creation.make:178: obj/x64/Debug/00_context_creation/SceneDemo.o] Error 1 make: *** [Makefile:112: 00_context_creation] Error 2

[meistdan]

Thank you for reporting this issue. Are you using binaries from GPUOpen or your own build? I've noticed that the binaries on GPUOpen are 2.4 while the source code is 2.5, where we changed the vector types. We need to update the binaries/SDK too.

[amerus]

I have tried many permutations. However, for this issue, I downloaded the binaries from GPUOpen. I see that Common.h of the most recent tutorials commit is still missing the needed definition.

[RichardGe]

should be fixed with https://github.com/GPUOpen-LibrariesAndSDKs/HIPRTSDK/commit/24ac11bcc06c4061983c0d9b71cbec8e1fe7ca7a. Thanks for your report.