Capsaicin icon indicating copy to clipboard operation
Capsaicin copied to clipboard

`g_ScreenProbes_OverrideTileBuffer` unused during adaptive sampling

Open Solicey opened this issue 1 year ago • 1 comments

https://github.com/GPUOpen-LibrariesAndSDKs/Capsaicin/blob/d642e5dbb35c443fe681936be7806dce1042b6cc/src/core/src/render_techniques/gi10/gi10.comp#L626 should be changed to:

InterlockedExchange(g_ScreenProbes_ProbeSpawnBuffer[g_ScreenProbes_OverrideTileBuffer[index]], ScreenProbes_PackSeed(seed), index);

so as to match with the GI-1.0 technical report.

Solicey avatar May 06 '24 14:05 Solicey

Thanks for reporting this, and you're correct, good spotting. We fixed this internally already and will include the fix in a subsequent update of Capsaicin.

gboisse avatar May 07 '24 14:05 gboisse