FidelityFX-FSR2 icon indicating copy to clipboard operation
FidelityFX-FSR2 copied to clipboard

fix missing override keyword

Open roidanton opened this issue 3 years ago • 2 comments

Did not use final b/c being not sure if these classes are ought to be subclassed by consumers.

roidanton avatar Jun 23 '22 12:06 roidanton

Didn't you just move the override keyword from the front of a function farther towards the end of its head?

AntonioNoack avatar Jun 26 '22 19:06 AntonioNoack

No. Having the override (or final) keyword in place enables a compile time check if the derived function signature exists in the base class. Using virtual on an already virtual function is meaningless and doesn't provide any compile time protection -> in case the function signature between a derived and the base class changes. the compiler wouldn't recognize and just add an additional function then.

roidanton avatar Jun 28 '22 14:06 roidanton