FFX_FSR2_ENABLE_MOTION_VECTORS_JITTER_CANCELLATION misses scaling factor

Open BartmanAbyss opened this issue 3 years ago • 4 comments

ffx_fsr2.cpp line 659, 660:

        context->constants.motionVectorJitterCancellation[0] = (context->previousJitterOffset[0] - context->constants.jitterOffset[0]) / motionVectorsTargetSize[0];
        context->constants.motionVectorJitterCancellation[1] = (context->previousJitterOffset[1] - context->constants.jitterOffset[1]) / motionVectorsTargetSize[1];

should be

        context->constants.motionVectorJitterCancellation[0] = (context->previousJitterOffset[0] - context->constants.jitterOffset[0]) / motionVectorsTargetSize[0] * context->constants.motionVectorScale[0];
        context->constants.motionVectorJitterCancellation[1] = (context->previousJitterOffset[1] - context->constants.jitterOffset[1]) / motionVectorsTargetSize[1] * context->constants.motionVectorScale[1];

Jul 20 '22 12:07 BartmanAbyss

How does this change affect resultant image reconstruction?

Jul 20 '22 15:07 Shidell

whole image jitters without this fix if FFX_FSR2_ENABLE_MOTION_VECTORS_JITTER_CANCELLATION is enabled in flags. FSR2Sample does not enable this flag.

Jul 20 '22 15:07 BartmanAbyss

yo @rys dude should we expect this getting fixed anytime soon?

Oct 20 '22 14:10 0x-FADED