ors-map-client icon indicating copy to clipboard operation
ors-map-client copied to clipboard
verified publisher icon GIScience

Add Czech language

Open trendspotter opened this issue 3 years ago • 1 comments

trendspotter avatar Mar 24 '22 19:03 trendspotter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Mar 24 '22 19:03 sonarqubecloud[bot]

I apologize, but I am unable to correct latest conflict for the PR to be accepted, please help

trendspotter avatar Dec 10 '22 09:12 trendspotter

Hey, don't worry about the failing checks, we'll sort that out later. Could you allow pull request edit for maintainers for this repo?

Then I'd commit a few changes - in particular, over half of the translation files are missing. The translation exists in the cs-translation-source-merged.json-file, and I have sorted them into their respective files locally. Once I have access, I can commit these changes and we can have a look at those files :)

That'd be great, thank you :)

koebi avatar Dec 13 '22 13:12 koebi

ok, I sent my translation 9 months ago, since then new texts have been written. So I should complete the current translation and make a new PR. Later...

I see the checkbox is checked.

trendspotter avatar Dec 13 '22 14:12 trendspotter

Hey, great, thanks :)) No worries, the translation is complete. I just added the files, will review them tomorrow again. Could you please also scan through them quickly to check that I didn't make any mistakes when copying from the merged translation file to the single files?

koebi avatar Dec 13 '22 15:12 koebi

Hey, thank you so much for addressing all these comments :)) There are two left, would you mind commenting on them as well? After that, we can wrap up the PR and have a czech version of the client :))

koebi avatar Jan 09 '23 11:01 koebi

Hey, thank you so much for addressing all these comments :)) There are two left, would you mind commenting on them as well? After that, we can wrap up the PR and have a czech version of the client :))

Hi, thanks for the reminder, I got a little lost, but I'll keep it in mind. Sorry.

trendspotter avatar Jan 10 '23 07:01 trendspotter

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Jan 12 '23 08:01 sonarqubecloud[bot]

Hey,

thanks for the updates :) From my point of view, this is ready for merge.

Unfortunately, since I contributed, I can't review anymore, but we'll have that done soon.

Thank you very much for your contribution!

Best regards

koebi avatar Jan 12 '23 08:01 koebi

Superseded by https://github.com/GIScience/ors-map-client/pull/319

TheGreatRefrigerator avatar Jan 12 '23 11:01 TheGreatRefrigerator